Skip to content

[seal] Update to SEAL 3.6.1#15015

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
kiromaru:UpdateSEAL361
Jan 28, 2021
Merged

[seal] Update to SEAL 3.6.1#15015
dan-shaw merged 1 commit intomicrosoft:masterfrom
kiromaru:UpdateSEAL361

Conversation

@kiromaru
Copy link
Copy Markdown
Contributor

@kiromaru kiromaru commented Dec 9, 2020

Update SEAL port to version 3.6.1

  • What does your PR fix? Updating to a new SEAL version

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Tested x64-windows-static, x64-linux, x64-osx
    x64-windows/x86-windows are not supported as the library only supports static linkage in Windows.

  • Does your PR follow the maintainer guide?
    Yes

@JonLiu1993 JonLiu1993 self-assigned this Dec 9, 2020
@JonLiu1993 JonLiu1993 requested a review from JackBoosY December 9, 2020 05:48
JackBoosY
JackBoosY suggested changes Dec 9, 2020
View reviewed changes
@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision requires:author-response and removed requires:author-response labels Dec 9, 2020
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Dec 10, 2020

@kiromaru ,The feature test on windows is successful, but there seems to be a problem with x64-linux on linux, can you take a look?

home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/gcc.h:10:19: error: SEAL requires __GNUC__ >= 6
 #pragma GCC error "SEAL requires __GNUC__ >= 6"
                   ^
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:6:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/encryptionparams.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:4:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/defines.h:120:28: error: ‘byte’ in namespace ‘std’ does not name a type
     using seal_byte = std::byte;
                            ^
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/globals.h:6:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:7,

/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/common.h: In function ‘constexpr T seal::util::mul_safe(T, T)’:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/defines.h:133:30: error: expected ‘(’ before ‘constexpr’
 #define SEAL_IF_CONSTEXPR if constexpr
                              ^
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/common.h:140:13: note: in expansion of macro ‘SEAL_IF_CONSTEXPR’
             SEAL_IF_CONSTEXPR(std::is_unsigned<T>::value)
             ^
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:347:1: error: expected ‘}’ at end of input
 } // namespace seal
 ^
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp: At global scope:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:347:1: error: expected ‘}’ at end of input
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:347:1: error: expected ‘}’ at end of input
[2/40] /usr/bin/c++  -I/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src -Inative/src -isystem /home/vzhli17/Jon/test2/vcpkg/installed/x64-linux/include -fPIC -Wall -Wextra -Wconversion -Wshadow -pedantic -g -fPIC -pthread -std=gnu++1z -MD -MT CMakeFiles/seal.dir/native/src/seal/context.cpp.o -MF CMakeFiles/seal.dir/native/src/seal/context.cpp.o.d -o CMakeFiles/seal.dir/native/src/seal/context.cpp.o -c /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.cpp
FAILED: CMakeFiles/seal.dir/native/src/seal/context.cpp.o
/usr/bin/c++  -I/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src -Inative/src -isystem /home/vzhli17/Jon/test2/vcpkg/installed/x64-linux/include -fPIC -Wall -Wextra -Wconversion -Wshadow -pedantic -g -fPIC -pthread -std=gnu++1z -MD -MT CMakeFiles/seal.dir/native/src/seal/context.cpp.o -MF CMakeFiles/seal.dir/native/src/seal/context.cpp.o.d -o CMakeFiles/seal.dir/native/src/seal/context.cpp.o -c /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.cpp
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/defines.h:106:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/encryptionparams.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.cpp:4:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/gcc.h:10:19: error: SEAL requires __GNUC__ >= 6
 #pragma GCC error "SEAL requires __GNUC__ >= 6"
                   ^
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:6:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/encryptionparams.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.h:6,

@kiromaru
Copy link
Copy Markdown
Contributor Author

kiromaru commented Dec 10, 2020

Hi JonLiu1993,
SEAL requires at least GCC 7, that is the cause of the error. Notice that the PR pipeline was able to build x64-linux without problems. I tested it locally as well.

@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 28, 2021
@dan-shaw dan-shaw merged commit 5546681 into microsoft:master Jan 28, 2021
@JackBoosY JackBoosY mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kiromaru @JonLiu1993 @JackBoosY @dan-shaw